On Sun, Dec 21, 2014 at 11:43 AM, Bruno Prémont <bonbons@xxxxxxxxxxxxxxxxx> wrote: > On !SMP systems spinlocks do not exist. Thus checking of they > are active will always fail. > > Use > assert_spin_locked(lock); > instead of > BUG_ON(!spin_is_locked(lock)); > to not BUG() on all UP systems. > > Signed-off-by: Bruno Prémont <bonbons@xxxxxxxxxxxxxxxxx> > --- > drivers/gpu/drm/omapdrm/omap_irq.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/omapdrm/omap_irq.c b/drivers/gpu/drm/omapdrm/omap_irq.c > index f035d2b..6ca9253 100644 > --- a/drivers/gpu/drm/omapdrm/omap_irq.c > +++ b/drivers/gpu/drm/omapdrm/omap_irq.c > @@ -34,7 +34,7 @@ static void omap_irq_update(struct drm_device *dev) > struct omap_drm_irq *irq; > uint32_t irqmask = priv->vblank_mask; > > - BUG_ON(!spin_is_locked(&list_lock)); > + assert_spin_locked(&list_lock)); btw, one too many ')' there... I've fixed up the same issue w/ msm patch as I applied it BR, -R > > list_for_each_entry(irq, &priv->irq_list, node) > irqmask |= irq->irqmask; > -- > 1.8.1.5 > > _______________________________________________ > dri-devel mailing list > dri-devel@xxxxxxxxxxxxxxxxxxxxx > http://lists.freedesktop.org/mailman/listinfo/dri-devel _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/dri-devel
