On Mon, Dec 15, 2014 at 5:50 PM, Dave Airlie <airlied@xxxxxxxxx> wrote: > > Now you might complain that printing anything in this case is bad, I don't mind it if it's *one* line, and if people realize that the commentary in the commit in question was pure and utter shit. Because talking about how it's going to become an error is pretty damn premature, if Xorg uses it today. That's part of what just made me really frigging upset. People applied this patch, didn't test it AT ALL, and the commit message is completely inappropriate crap. Having a quiet deprecation warning with the understanding that things will stay around for *years* is fine. Although it makes me wonder how much value the deprecation message really adds. I mean, why the hell print a message, when the only correct thing to do is to just look at and fix Xorg? And if you can't get Xorg fixed, then the message is kind of pointless too? So really, I don't see the point of even a oneliner message. You guys know who the user is. There's no value in the message. Either you fix the user or you don't. It's not like "oh, it's Xorg that uses our drm interfaces" is a big surprise, is it? Linus _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/dri-devel