On Sun, 07 Dec 2014, Rickard Strandqvist <rickard_strandqvist@xxxxxxxxxxxxxxxxxx> wrote:
> Remove the function dsi_hs_mode_enable() that is not used anywhere.
Please don't.
BR,
Jani.
>
> This was partially found by using a static code analysis program called cppcheck.
>
> Signed-off-by: Rickard Strandqvist <rickard_strandqvist@xxxxxxxxxxxxxxxxxx>
> ---
> drivers/gpu/drm/i915/intel_dsi_cmd.c | 21 ---------------------
> drivers/gpu/drm/i915/intel_dsi_cmd.h | 2 --
> 2 files changed, 23 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_dsi_cmd.c b/drivers/gpu/drm/i915/intel_dsi_cmd.c
> index f4767fd..71addcc 100644
> --- a/drivers/gpu/drm/i915/intel_dsi_cmd.c
> +++ b/drivers/gpu/drm/i915/intel_dsi_cmd.c
> @@ -103,27 +103,6 @@ enum dsi_type {
> DSI_GENERIC,
> };
>
> -/* enable or disable command mode hs transmissions */
> -void dsi_hs_mode_enable(struct intel_dsi *intel_dsi, bool enable)
> -{
> - struct drm_encoder *encoder = &intel_dsi->base.base;
> - struct drm_device *dev = encoder->dev;
> - struct drm_i915_private *dev_priv = dev->dev_private;
> - struct intel_crtc *intel_crtc = to_intel_crtc(encoder->crtc);
> - enum pipe pipe = intel_crtc->pipe;
> - u32 temp;
> - u32 mask = DBI_FIFO_EMPTY;
> -
> - if (wait_for((I915_READ(MIPI_GEN_FIFO_STAT(pipe)) & mask) == mask, 50))
> - DRM_ERROR("Timeout waiting for DBI FIFO empty\n");
> -
> - temp = I915_READ(MIPI_HS_LP_DBI_ENABLE(pipe));
> - temp &= DBI_HS_LP_MODE_MASK;
> - I915_WRITE(MIPI_HS_LP_DBI_ENABLE(pipe), enable ? DBI_HS_MODE : DBI_LP_MODE);
> -
> - intel_dsi->hs = enable;
> -}
> -
> static int dsi_vc_send_short(struct intel_dsi *intel_dsi, int channel,
> u8 data_type, u16 data)
> {
> diff --git a/drivers/gpu/drm/i915/intel_dsi_cmd.h b/drivers/gpu/drm/i915/intel_dsi_cmd.h
> index 46aa1ac..7ad54c0 100644
> --- a/drivers/gpu/drm/i915/intel_dsi_cmd.h
> +++ b/drivers/gpu/drm/i915/intel_dsi_cmd.h
> @@ -36,8 +36,6 @@
> #define DPI_LP_MODE_EN false
> #define DPI_HS_MODE_EN true
>
> -void dsi_hs_mode_enable(struct intel_dsi *intel_dsi, bool enable);
> -
> int dsi_vc_dcs_write(struct intel_dsi *intel_dsi, int channel,
> const u8 *data, int len);
>
> --
> 1.7.10.4
>
--
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/dri-devel
