On Tue, Nov 25, 2014 at 01:50:25PM +0100, SF Markus Elfring wrote: > From: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx> You can probably get rid of this if you configure your emailer properly. > Date: Tue, 25 Nov 2014 13:44:20 +0100 This is odd. I've never seen git send-email generate these. I didn't notice with your earlier patches, but the subject prefix is wrong. Please use something more consistent with existing patches, in this case: "drm/msm: ..." or "drm/msm/adreno: ..." > The release_firmware() function tests whether its argument is NULL > and then returns immediately. Thus the test around the call is not needed. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx> > --- > drivers/gpu/drm/msm/adreno/adreno_gpu.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/gpu/drm/msm/adreno/adreno_gpu.c b/drivers/gpu/drm/msm/adreno/adreno_gpu.c > index 655ce5b..757052c 100644 > --- a/drivers/gpu/drm/msm/adreno/adreno_gpu.c > +++ b/drivers/gpu/drm/msm/adreno/adreno_gpu.c > @@ -404,9 +404,7 @@ void adreno_gpu_cleanup(struct adreno_gpu *gpu) > msm_gem_put_iova(gpu->memptrs_bo, gpu->base.id); > drm_gem_object_unreference(gpu->memptrs_bo); > } > - if (gpu->pm4) > - release_firmware(gpu->pm4); > - if (gpu->pfp) > - release_firmware(gpu->pfp); > + release_firmware(gpu->pm4); > + release_firmware(gpu->pfp); > msm_gpu_cleanup(&gpu->base); > } Besides the subject prefix, Reviewed-by: Thierry Reding <treding@xxxxxxxxxx>
Attachment:
pgpvRsQN3KDfY.pgp
Description: PGP signature
_______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/dri-devel
