On Mon, Nov 24, 2014 at 7:25 AM, Mike Looijmans <mike.looijmans@xxxxxxxx> wrote: > Building the adi_axi_hdmi driver as a module failed: > ERROR: "drm_sysfs_connector_remove" [drivers/gpu/drm/adi_axi_hdmi/adi_axi_hdmi.ko] undefined! > > Mark drm_sysfs_connector_remove for export to fix this. Also mark > drm_sysfs_connector_add for export, for symetry and because at least > one other module uses it (xylon_connector.c). no.. you should be using drm_connector_{register,unregister}() now, and not calling the drm_sysfs_connector_{add,remove}() fxns directly.. BR, -R > Signed-off-by: Mike Looijmans <mike.looijmans@xxxxxxxx> > --- > drivers/gpu/drm/drm_sysfs.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/gpu/drm/drm_sysfs.c b/drivers/gpu/drm/drm_sysfs.c > index ab1a5f6..d0296cc 100644 > --- a/drivers/gpu/drm/drm_sysfs.c > +++ b/drivers/gpu/drm/drm_sysfs.c > @@ -438,6 +438,7 @@ err_out_files: > out: > return ret; > } > +EXPORT_SYMBOL(drm_sysfs_connector_add); > > /** > * drm_sysfs_connector_remove - remove an connector device from sysfs > @@ -467,6 +468,7 @@ void drm_sysfs_connector_remove(struct drm_connector *connector) > device_unregister(connector->kdev); > connector->kdev = NULL; > } > +EXPORT_SYMBOL(drm_sysfs_connector_remove); > > /** > * drm_sysfs_hotplug_event - generate a DRM uevent > -- > 1.7.9.5 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/dri-devel