Pass the pointer to DC channel to ipu_dc_enable() and ipu_dc_disable(), to be more consistent with the other ipu-dc APIs. Signed-off-by: Steve Longerbeam <steve_longerbeam@xxxxxxxxxx> --- drivers/gpu/ipu-v3/ipu-dc.c | 12 ++++++++---- drivers/staging/imx-drm/ipuv3-crtc.c | 8 ++------ include/video/imx-ipu-v3.h | 4 ++-- 3 files changed, 12 insertions(+), 12 deletions(-) diff --git a/drivers/gpu/ipu-v3/ipu-dc.c b/drivers/gpu/ipu-v3/ipu-dc.c index 6992f84..f53fce5 100644 --- a/drivers/gpu/ipu-v3/ipu-dc.c +++ b/drivers/gpu/ipu-v3/ipu-dc.c @@ -341,9 +341,11 @@ void ipu_dc_uninit_sync(struct ipu_dc *dc) } EXPORT_SYMBOL_GPL(ipu_dc_uninit_sync); -void ipu_dc_enable(struct ipu_soc *ipu) +void ipu_dc_enable(struct ipu_dc *dc) { - ipu_module_enable(ipu, IPU_CONF_DC_EN); + struct ipu_dc_priv *priv = dc->priv; + + ipu_module_enable(priv->ipu, IPU_CONF_DC_EN); } EXPORT_SYMBOL_GPL(ipu_dc_enable); @@ -403,9 +405,11 @@ void ipu_dc_disable_channel(struct ipu_dc *dc) } EXPORT_SYMBOL_GPL(ipu_dc_disable_channel); -void ipu_dc_disable(struct ipu_soc *ipu) +void ipu_dc_disable(struct ipu_dc *dc) { - ipu_module_disable(ipu, IPU_CONF_DC_EN); + struct ipu_dc_priv *priv = dc->priv; + + ipu_module_disable(priv->ipu, IPU_CONF_DC_EN); } EXPORT_SYMBOL_GPL(ipu_dc_disable); diff --git a/drivers/staging/imx-drm/ipuv3-crtc.c b/drivers/staging/imx-drm/ipuv3-crtc.c index 25c0231..7053619 100644 --- a/drivers/staging/imx-drm/ipuv3-crtc.c +++ b/drivers/staging/imx-drm/ipuv3-crtc.c @@ -60,12 +60,10 @@ struct ipu_crtc { static void ipu_fb_enable(struct ipu_crtc *ipu_crtc) { - struct ipu_soc *ipu = dev_get_drvdata(ipu_crtc->dev->parent); - if (ipu_crtc->enabled) return; - ipu_dc_enable(ipu); + ipu_dc_enable(ipu_crtc->dc); ipu_plane_enable(ipu_crtc->plane[0]); /* Start DC channel and DI after IDMAC */ ipu_dc_enable_channel(ipu_crtc->dc); @@ -76,8 +74,6 @@ static void ipu_fb_enable(struct ipu_crtc *ipu_crtc) static void ipu_fb_disable(struct ipu_crtc *ipu_crtc) { - struct ipu_soc *ipu = dev_get_drvdata(ipu_crtc->dev->parent); - if (!ipu_crtc->enabled) return; @@ -85,7 +81,7 @@ static void ipu_fb_disable(struct ipu_crtc *ipu_crtc) ipu_dc_disable_channel(ipu_crtc->dc); ipu_di_disable(ipu_crtc->di); ipu_plane_disable(ipu_crtc->plane[0]); - ipu_dc_disable(ipu); + ipu_dc_disable(ipu_crtc->dc); ipu_crtc->enabled = 0; } diff --git a/include/video/imx-ipu-v3.h b/include/video/imx-ipu-v3.h index 758c773..36309b9 100644 --- a/include/video/imx-ipu-v3.h +++ b/include/video/imx-ipu-v3.h @@ -246,10 +246,10 @@ void ipu_dc_put(struct ipu_dc *dc); int ipu_dc_init_sync(struct ipu_dc *dc, struct ipu_di *di, bool interlaced, u32 pixel_fmt, struct ipu_dc_if_map *new_map, u32 width); void ipu_dc_uninit_sync(struct ipu_dc *dc); -void ipu_dc_enable(struct ipu_soc *ipu); +void ipu_dc_enable(struct ipu_dc *dc); void ipu_dc_enable_channel(struct ipu_dc *dc); void ipu_dc_disable_channel(struct ipu_dc *dc); -void ipu_dc_disable(struct ipu_soc *ipu); +void ipu_dc_disable(struct ipu_dc *dc); /* * IPU Display Interface (di) functions -- 1.7.9.5 _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/dri-devel