On Fri, Oct 24, 2014 at 05:57:24PM -0400, Rob Clark wrote: > Oh, you are only looking at the one in mdp4_kms_init(), which could > possibly be a simple regulator_get(). Look instead at the ones in > hdmi_init(), where I need to know whether to defer or not. At one No, I saw that - looking at the code in hdmi_init() it's using normal devm_regulator_get() correctly (it appears to be open coding devm_regulator_bulk_get() and likewise for the enables and disables but that's a lot less serious). I can't see anything actively broken with that code other than the error handling on failed enable. > point I was having a problem getting dummy regulators with > regulator_get() but that could have been a symptom of another problem. > I will re-try regulator_get() next time I am working on the kernel > part of the driver.. It's a bug elsewhere, if you are getting a dummy regulator on a DT system it means that you don't have a regulator set up for that supply so the core is just assuming that it's always on.
Attachment:
signature.asc
Description: Digital signature
_______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/dri-devel
