Re: [PATCH] drm/dp-helper: Move the legacy helpers to gma500

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Oct 22, 2014 at 5:34 PM, Alan Cox <alan@xxxxxxxxxxxxxxxxxxx> wrote:
> On Wed, 22 Oct 2014 16:32:52 +0200
> Patrik Jakobsson <patrik.r.jakobsson@xxxxxxxxx> wrote:
>
>> On Wed, Oct 22, 2014 at 11:16 AM, Daniel Vetter <daniel.vetter@xxxxxxxx> wrote:
>> > Except for gma500 all drivers are converted to the new style helpers,
>> > which have much better abstraction of the underlying hw protocols and
>> > already much more helper functions (including the entire mst library)
>> > on top of them. Since no one seems to work on converting gma500 let's
>> > just move the code away so that new drivers don't end up accidentally
>> > using this.
>>
>> Thanks for doing this! I'll CC Alan as well.
>
> Reviewed-by: Alan Cox <alan@xxxxxxxxxxxxxxx>
>
> Please consider adding an __deprecated marker to one of the top functions
> so it irritates me or someone else into cleaning it up properly

Done. Also added a short FIXME comment so that you don't have to check
with git blame why this is deprecated. And I dropped the EXPORT_SYMBOL
which is no longer needed, too.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/dri-devel




[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux