Re: [PATCH 4/8] drm: Move drm_vm_open_locked into drm_internal.h

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Sep 23, 2014 at 04:15:05PM +0200, David Herrmann wrote:
> Hi
> 
> On Tue, Sep 23, 2014 at 3:46 PM, Daniel Vetter <daniel.vetter@xxxxxxxx> wrote:
> > Leftover from my previous header cleanup.
> >
> > This depends upon the patch to rework exynos mmap support, otherwise
> > it'll break exynos.
> 
> What patch do you mean? I cannot see any users of drm_vm_open_locked()
> anywhere besides drm_gem.c and drm_vm.c, (branch drm-next).

Only since exynos-next was pulled in yesterday, which is why I've now sent
these out. I'll reword the commit message to reflect this.
-Daniel

> 
> Reviewed-by: David Herrmann <dh.herrmann@xxxxxxxxx>
> 
> Thanks
> David
> 
> >
> > Signed-off-by: Daniel Vetter <daniel.vetter@xxxxxxxxx>
> > ---
> >  drivers/gpu/drm/drm_internal.h | 1 +
> >  drivers/gpu/drm/drm_vm.c       | 1 -
> >  include/drm/drmP.h             | 1 -
> >  3 files changed, 1 insertion(+), 2 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/drm_internal.h b/drivers/gpu/drm/drm_internal.h
> > index d27faae45f1b..05624561118a 100644
> > --- a/drivers/gpu/drm/drm_internal.h
> > +++ b/drivers/gpu/drm/drm_internal.h
> > @@ -37,6 +37,7 @@ int drm_irq_by_busid(struct drm_device *dev, void *data,
> >
> >  /* drm_vm.c */
> >  int drm_vma_info(struct seq_file *m, void *data);
> > +void drm_vm_open_locked(struct drm_device *dev, struct vm_area_struct *vma);
> >  void drm_vm_close_locked(struct drm_device *dev, struct vm_area_struct *vma);
> >
> >  /* drm_prime.c */
> > diff --git a/drivers/gpu/drm/drm_vm.c b/drivers/gpu/drm/drm_vm.c
> > index e36c5cb2733b..ac33f7d1ee35 100644
> > --- a/drivers/gpu/drm/drm_vm.c
> > +++ b/drivers/gpu/drm/drm_vm.c
> > @@ -421,7 +421,6 @@ void drm_vm_open_locked(struct drm_device *dev,
> >                 list_add(&vma_entry->head, &dev->vmalist);
> >         }
> >  }
> > -EXPORT_SYMBOL_GPL(drm_vm_open_locked);
> >
> >  static void drm_vm_open(struct vm_area_struct *vma)
> >  {
> > diff --git a/include/drm/drmP.h b/include/drm/drmP.h
> > index 24aa38236367..9f1abd51ded2 100644
> > --- a/include/drm/drmP.h
> > +++ b/include/drm/drmP.h
> > @@ -961,7 +961,6 @@ extern ssize_t drm_read(struct file *filp, char __user *buffer,
> >  extern int drm_release(struct inode *inode, struct file *filp);
> >
> >                                 /* Mapping support (drm_vm.h) */
> > -extern void drm_vm_open_locked(struct drm_device *dev, struct vm_area_struct *vma);
> >  extern unsigned int drm_poll(struct file *filp, struct poll_table_struct *wait);
> >
> >  /* Misc. IOCTL support (drm_ioctl.c) */
> > --
> > 2.1.0
> >
> > _______________________________________________
> > dri-devel mailing list
> > dri-devel@xxxxxxxxxxxxxxxxxxxxx
> > http://lists.freedesktop.org/mailman/listinfo/dri-devel

-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/dri-devel




[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux