On Fr, 2014-09-19 at 10:37 +0200, David Herrmann wrote: > Hi > > On Fri, Sep 19, 2014 at 10:11 AM, Gerd Hoffmann <kraxel@xxxxxxxxxx> wrote: > > Signed-off-by: Gerd Hoffmann <kraxel@xxxxxxxxxx> > > --- > > drivers/gpu/drm/cirrus/cirrus_mode.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/drivers/gpu/drm/cirrus/cirrus_mode.c b/drivers/gpu/drm/cirrus/cirrus_mode.c > > index e1c5c32..c7c5a9d 100644 > > --- a/drivers/gpu/drm/cirrus/cirrus_mode.c > > +++ b/drivers/gpu/drm/cirrus/cirrus_mode.c > > @@ -555,6 +555,7 @@ static struct drm_connector *cirrus_vga_init(struct drm_device *dev) > > > > drm_connector_helper_add(connector, &cirrus_vga_connector_helper_funcs); > > > > + drm_connector_register(connector); > > Error checking? Hmm, I see plenty of calls like this in the kernel. Also: What should happen on error? The driver itself and cirrusdrmfb works just fine without that, so I don't feel like failing driver initialization because of that, as that would break the console ... > And should probably include "Cc: <stable@xxxxxxxxxxxxxxx> # v3.15+". Commit 2ee39452fa2fff1e8edb954ccb7e0daee9646557 (v3.17 merge window) exposes the bug, so stable kernels are working just fine. cheers, Gerd _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/dri-devel
