Re: [PATCH 6/8] drm/radeon: cope with foreign fences inside the reservation object

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 18.09.2014 19:22, Maarten Lankhorst wrote:
Op 18-09-14 om 05:26 schreef Michel Dänzer:
On 17.09.2014 21:35, Maarten Lankhorst wrote:
diff --git a/drivers/gpu/drm/radeon/radeon_semaphore.c b/drivers/gpu/drm/radeon/radeon_semaphore.c
index 4d4b0773638a..68311da39c09 100644
--- a/drivers/gpu/drm/radeon/radeon_semaphore.c
+++ b/drivers/gpu/drm/radeon/radeon_semaphore.c
@@ -124,27 +124,39 @@ void radeon_semaphore_sync_fence(struct radeon_semaphore *semaphore,
    *
    * Sync to the fence using this semaphore object
    */
-void radeon_semaphore_sync_resv(struct radeon_semaphore *sema,
-                struct reservation_object *resv,
-                bool shared)
+int radeon_semaphore_sync_resv(struct radeon_device *rdev,
+                   struct radeon_semaphore *sema,
+                   struct reservation_object *resv,
+                   bool shared, bool intr)

The callers of this function would be more readable if it took flags instead of the shared and intr bools.
This does not match the rest of the TTM design. Things like
ttm_bo_reserve take separate bools, not flags.

So? :)


--
Earthling Michel Dänzer            |                  http://www.amd.com
Libre software enthusiast          |                Mesa and X developer
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/dri-devel





[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux