Comment # 89
on bug 60879
from Michel Dänzer
(In reply to comment #88) > Is this patch supposed to apply cleanly against mesa 10.1.5? No, looks like it's for Git master, should probably apply against the 10.3 branch at least though. (In reply to comment #87) > Fix v3 [...] > + for (i = 0; i < num_se; i++) { > + si_pm4_set_reg(pm4, GRBM_GFX_INDEX, > + SE_INDEX(i) | > + SH_BROADCAST_WRITES | > + INSTANCE_BROADCAST_WRITES); > + si_pm4_set_reg(pm4, R_028350_PA_SC_RASTER_CONFIG, raster_config); > + } Since this uses the same raster_config value for all SEs, couldn't it just use a single write with SE_BROADCAST_WRITES enabled in GRBM_GFX_INDEX? If not: > + unsigned sh_per_se = MAX2(sctx->screen->b.info.max_sh_per_se, 1); > + unsigned num_se = MAX2(sctx->screen->b.info.max_sh_per_se, 1); sh_per_se and num_se have the same value. Should one of them be calculated differently, or does a single variable suffice?
You are receiving this mail because:
- You are the assignee for the bug.
_______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/dri-devel
