2014-09-02 14:51 GMT+02:00 Ezequiel Garcia <ezequiel@xxxxxxxxxxxxxxxxxxxx>: > Dave, > > I'm resending this, hoping it can be pushed for v3.18. The patchset was > ready for v3.17, but it got no maintainer feedback or review. Maybe it fell > through some crack? > > Just for reference, here goes the details about this series and why it's > needed: > > This patchset adds the required changes to support an optional backlight > and GPIO for the tilcdc panel driver. > > There was some code to support a backlight, but it was broken and undocumented. > I've followed the nice implementation in panel-simple and added a similar > one here. > > The enable GPIO is required to turn on and off devices with such capability. > Also here, I've followed panel-simple which looks correct. > > In addition to this there are very minor cosmetic cleanups and a larger > fix for the error path in tilcdc's DRM driver .load error path. > I tested the series with 3.16.1 (with additonal patches from Guido and Sachin) and with 3.17-rc3 with a custom AM335x board and it worked for me without an issue. I tried it with and without the backlight addition in the dts file. For the series: Tested-by: Johannes Pointner <johannes.pointner@xxxxxxxxxxxxxxxxx> > Ezequiel Garcia (8): > drm/tilcdc: Fix the error path in tilcdc_load() > drm/tilcdc: panel: Add missing of_node_put > drm/tilcdc: panel: Remove unused variable > drm/tilcdc: panel: Spurious whitespace removal > drm/tilcdc: panel: Use devm_kzalloc to simplify the error path > drm/tilcdc: panel: Fix backlight devicetree support > drm/tilcdc: panel: Set return value explicitly > drm/tilcdc: panel: Add support for enable GPIO > > .../devicetree/bindings/drm/tilcdc/panel.txt | 7 ++ > drivers/gpu/drm/tilcdc/tilcdc_drv.c | 60 +++++++++++++++--- > drivers/gpu/drm/tilcdc/tilcdc_panel.c | 74 +++++++++++++++++----- > 3 files changed, 114 insertions(+), 27 deletions(-) > > -- > 2.0.1 > _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/dri-devel