On Fri, Aug 29, 2014 at 12:12:28PM +0200, David Herrmann wrote: > Move internal declarations to drm_legacy.h and add drm_legacy_*() prefix > to all legacy functions. Perhaps this could give a short explanation of why they are marked as legacy and what the plan is to get rid of them. [...] > diff --git a/drivers/gpu/drm/drm_bufs.c b/drivers/gpu/drm/drm_bufs.c [...] > @@ -378,7 +374,7 @@ int drm_addmap(struct drm_device * dev, resource_size_t offset, > return rc; > } > > -EXPORT_SYMBOL(drm_addmap); > +EXPORT_SYMBOL(drm_legacy_addmap); Nit: might as well remove the unusual blank line between the closing brace and the EXPORT_SYMBOL while at it. > diff --git a/drivers/gpu/drm/mga/mga_dma.c b/drivers/gpu/drm/mga/mga_dma.c [...] > offset = 0; > - err = drm_addmap(dev, offset, warp_size, > - _DRM_AGP, _DRM_READ_ONLY, &dev_priv->warp); > + err = drm_legacy_addmap(dev, offset, warp_size, > + _DRM_AGP, _DRM_READ_ONLY, &dev_priv->warp); The parameters are somewhat oddly wrapped here. Nothing that the patch introduces, but perhaps low-hanging fruit while at it. There are a few other occurrences in this file. I found only minor whitespace nits, feel free to ignore those. Reviewed-by: Thierry Reding <treding@xxxxxxxxxx>
Attachment:
pgpqMDvGKjjCi.pgp
Description: PGP signature
_______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/dri-devel
