Hi Emil, sorry for the delay. I still see the same patch error for patch 3/8. The patch diff for intel/makefile.am has as part of its context: # Eric Anholt <eric at anholt.net> Whereas the source file has # Eric Anholt <eric@xxxxxxxxxx> So the patch fails. Its trivial of course. Perhaps there is some automatic Substitution getting done by some tool. Maybe git-am will automatically Fix this, not sure, I don't have a workflow for git-am. My source comes from Git://anongit.freedesktop.org/git/mesa/drm Remote =origin Merge = refs/heads/master Other than that, as I say the patches look fine, and I have successfully built Libdrm in an Android tree using these patches and "mm". I am out of the office from 12:00 until Thurs 4th Sept now. Tim > -----Original Message----- > From: Emil Velikov [mailto:emil.l.velikov@xxxxxxxxx] > Sent: Sunday, August 24, 2014 7:40 PM > To: Gore, Tim; dri-devel@xxxxxxxxxxxxxxxxxxxxx > Cc: emil.l.velikov@xxxxxxxxx; Daniel Vetter (daniel@xxxxxxxx) > Subject: Re: [PATCHv2 0/8] Upstreaming the Android build and misc fixes > > Hi Tim, > > Gave the series another try, and there was some minor issues caused by > commit > 5d8357976a8 (configure: Support symbol visibility when available). Did not > see any of the originally mentioned issues. Are you sure that you've tried it > on top of fd.o/drm/master ? > > Do you have any comments, would like to do any testing (note it will not > work due to the mmap/mmap64 bionic issue, to be addressed next) or > should I go ahead and commit the series ? > > Thanks > Emil > > The series: > http://lists.freedesktop.org/archives/dri-devel/2014-July/064952.html > > Patchv3 3/8: > http://lists.freedesktop.org/archives/dri-devel/2014-August/066748.html > > > On 31/07/14 19:32, Emil Velikov wrote: > > Strange, I've explicitly made sure that it's rebased on top of libdrm/master. > > I will give it another try in a moment. > > > > FWIW, for Intel at least a mmap/mmap64 would be needed due to the > > bionic shortage of their original implementation. > > > > As mentioned earlier, I'm seeking for a few acked/reviewed-by and the > > rest of the fixes will follow in due time. Can I consider this acked-by ? > > > > Thanks for having a look > > -Emil > > > > On 31/07/14 16:33, Gore, Tim wrote: > >> Ok, I still had to manually apply some of patch 3/8 as it was > >> corrupted And would not apply, but after this I was able to build > >> within one of My android trees. I have not tested the resulting > >> libraries yet, but the Overall build process seems ok. > >> > >> Tim > >> > >>> -----Original Message----- > >>> From: Emil Velikov [mailto:emil.l.velikov@xxxxxxxxx] > >>> Sent: Tuesday, July 29, 2014 6:27 PM > >>> To: dri-devel@xxxxxxxxxxxxxxxxxxxxx > >>> Cc: Gore, Tim > >>> Subject: [PATCHv2 0/8] Upstreaming the Android build and misc fixes > >>> > >>> Changes since the orignal posting: > >>> - Rebased on top of master. > >>> - Used _H_FILES for header lists (_HEADERS is a no-go with > >>> autotools) > >>> - Install the freedreno headers to {include_dir}/freedreno, similar > >>> to the automake builds. > >>> - Correctly include $(hw)/Android.mk > >>> > >>> The series is also available at the fixes+android-v2 branch in > >>> https://github.com/evelikov/libdrm. > >>> > >>> -Emil > >> > > _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/dri-devel
