On 30 July 2014 07:32, Daniel Vetter <daniel.vetter@xxxxxxxx> wrote: > Atomic implemenations for legacy ioctls must be able to drop locks. > Which doesn't cause havoc since we only do that while constructing > the new state, so no driver or hardware state change has happened. > > The only troubling bit is the fb refcounting the core does - if > someone else has snuck in then it might potentially unref an > outdated framebuffer. To fix that move the old_fb temporary storage > into struct drm_plane for all ioctls, so that the atomic helpers can > update it. > > Signed-off-by: Daniel Vetter <daniel.vetter@xxxxxxxx> Seems to make sense to me. Reviewed-by: Dave Airlie <airlied@xxxxxxxxxx> _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/dri-devel