Re: [PATCH] drm/radeon: tweak ACCEL_WORKING2 query for hawaii

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Jul 29, 2014 at 11:39 AM, Jerome Glisse <j.glisse@xxxxxxxxx> wrote:
> On Tue, Jul 29, 2014 at 10:33:18AM -0400, Alex Deucher wrote:
>> Return 2 so we can be sure the kernel has the necessary
>> changes for acceleration to work.
>
> I highly dislike that ? Why about just using nop2 in userspace ?

How to we tell whether the version of mesa has that change or not?
Also, packet2 nops are deprecated so may not work in future firmwares
if we end up updating them again.

Alex

>
>>
>> Signed-off-by: Alex Deucher <alexander.deucher@xxxxxxx>
>> ---
>>  drivers/gpu/drm/radeon/radeon_kms.c | 9 ++++++++-
>>  1 file changed, 8 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/radeon/radeon_kms.c b/drivers/gpu/drm/radeon/radeon_kms.c
>> index 35d9318..dcec4ff 100644
>> --- a/drivers/gpu/drm/radeon/radeon_kms.c
>> +++ b/drivers/gpu/drm/radeon/radeon_kms.c
>> @@ -254,7 +254,14 @@ static int radeon_info_ioctl(struct drm_device *dev, void *data, struct drm_file
>>               }
>>               break;
>>       case RADEON_INFO_ACCEL_WORKING2:
>> -             *value = rdev->accel_working;
>> +             if (rdev->family == CHIP_HAWAII) {
>> +                     if (rdev->accel_working && rdev->new_fw)
>> +                             *value = 2;
>> +                     else
>> +                             *value = 0;
>> +             } else {
>> +                     *value = rdev->accel_working;
>> +             }
>>               break;
>>       case RADEON_INFO_TILING_CONFIG:
>>               if (rdev->family >= CHIP_BONAIRE)
>> --
>> 1.8.3.1
>>
>> _______________________________________________
>> dri-devel mailing list
>> dri-devel@xxxxxxxxxxxxxxxxxxxxx
>> http://lists.freedesktop.org/mailman/listinfo/dri-devel
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/dri-devel




[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux