Hi On Wed, Jul 23, 2014 at 9:26 PM, Daniel Vetter <daniel@xxxxxxxx> wrote: > On Wed, Jul 23, 2014 at 05:26:39PM +0200, David Herrmann wrote: >> The ctxbitmap code is only used by legacy drivers so lets try to keep it >> as separated as possible. Furthermore, the locking is non-obvious and >> kinda weird with ctxlist_mutex *and* struct_mutex. Keeping all ctxbitmap >> access in one file is much easier to review and makes drm_release() more >> readable. >> >> Signed-off-by: David Herrmann <dh.herrmann@xxxxxxxxx> > > I've started to sprinkle _legacy_ over all the functions only used for > non-kms drivers, so that the dragon dungeons are clearly marked off. With > that this is Reviewed-by: Daniel Vetter <daniel.vetter@xxxxxxxx>. Yeah, that sounds good. But I'd prefer if we keep this patch as-is and I will send a follow-up which renames all "drm_ctxbitmap_*" functions to "drm_legacy_ctxbitmap_*". All those are internal to DRM-core so I can rename them all together and add drivers/gpu/drm/drm-legacy.h. Comments? David _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/dri-devel
