Re: [PATCH] drm/radeon: fix irq ring buffer overflow handling

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Am 23.07.2014 11:07, schrieb Michel Dänzer:
On 23.07.2014 16:47, Christian König wrote:
From: Christian König <christian.koenig@xxxxxxx>

We must mask out the overflow bit as well, otherwise
the wptr will never match the rptr again and the interrupt
handler will loop forever.

Signed-off-by: Christian König <christian.koenig@xxxxxxx>
Reviewed-by: Michel Dänzer <michel.daenzer@xxxxxxx>


Cc: stable@xxxxxxxxxxxxxxx
Not sure this is justified though. Were you able to reproduce the
problem and verify the fix?
Not yet, reproducing ring buffer overflows aren't easy to do. But I've had that multiple times with CIK and userptr support work and I can try if I can reproduce it once more.

From reading the code it looks like a rather fundamental problem to me and because of this I've added the stable Cc.

Christian.
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/dri-devel





[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux