Hi Stephane, On Mon, Jul 7, 2014 at 8:04 PM, Stephane Viau <sviau@xxxxxxxxxxxxxx> wrote: > > MDP5 has several functional blocks (ie: VIG/RGB pipes, LMs, ...). > From one revision to another, these blocks' base addresses might > change due to the number of instances present in the MDP5 hw. .. > -static inline uint32_t REG_MDP5_PIPE(enum mdp5_pipe i0) { return 0x00001200 + 0x400*i0; } > +static inline uint32_t __offset_PIPE(enum mdp5_pipe idx) > +{ ERROR: switch and case should be at the same indent > + switch (idx) { > + case SSPP_VIG0: return (mdp5_cfg->pipe_vig.base[0]); > + case SSPP_VIG1: return (mdp5_cfg->pipe_vig.base[1]); > + case SSPP_VIG2: return (mdp5_cfg->pipe_vig.base[2]); .. > -static inline uint32_t REG_MDP5_LM(uint32_t i0) { return 0x00003200 + 0x400*i0; } > +static inline uint32_t __offset_LM(uint32_t idx) > +{ ERROR: switch and case should be at the same indent > + switch (idx) { > + case 0: return (mdp5_cfg->lm.base[0]); > + case 1: return (mdp5_cfg->lm.base[1]); > + case 2: return (mdp5_cfg->lm.base[2]); .. > -static inline uint32_t REG_MDP5_DSPP(uint32_t i0) { return 0x00004600 + 0x400*i0; } > +static inline uint32_t __offset_DSPP(uint32_t idx) > +{ ERROR: switch and case should be at the same indent > + switch (idx) { > + case 0: return (mdp5_cfg->dspp.base[0]); > + case 1: return (mdp5_cfg->dspp.base[1]); > + case 2: return (mdp5_cfg->dspp.base[2]); > + case 3: return (mdp5_cfg->dspp.base[3]); .. > -static inline uint32_t REG_MDP5_INTF(uint32_t i0) { return 0x00012500 + 0x200*i0; } > +static inline uint32_t __offset_INTF(uint32_t idx) > +{ ERROR: switch and case should be at the same indent > + switch (idx) { > + case 0: return (mdp5_cfg->intf.base[0]); > + case 1: return (mdp5_cfg->intf.base[1]); > + case 2: return (mdp5_cfg->intf.base[2]); .. > -static inline uint32_t REG_MDP5_AD(uint32_t i0) { return 0x00013100 + 0x200*i0; } > +static inline uint32_t __offset_AD(uint32_t idx) > +{ ERROR: switch and case should be at the same indent > + switch (idx) { > + case 0: return (mdp5_cfg->ad.base[0]); > + case 1: return (mdp5_cfg->ad.base[1]); > + default: return INVALID_IDX(idx); > + } > +} .. > } > -- > The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, > hosted by The Linux Foundation _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/dri-devel