On Thu, Jul 10, 2014 at 03:38:33PM -0700, Joe Perches wrote: > On Fri, 2014-07-11 at 00:50 +0300, Oded Gabbay wrote: > > This patch adds the interface between the radeon driver and the kfd > > driver. The interface implementation is contained in > > radeon_kfd.c and radeon_kfd.h. > [] > > include/linux/radeon_kfd.h | 67 ++++++++++++++++++++++++++ > > Is there a good reason to put this file in include/linux? > Agrees, we do not want to clutter include/linux/ with specific driver include, i think its one of the rules even thought there is some hw header already in there. I would rather see either a new dir include/hsa or inside include/drm. Cheers, Jérôme _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/dri-devel