On Tue, Jul 08, 2014 at 01:40:44PM +0200, Thomas Hellstrom wrote: > On 07/08/2014 01:24 PM, Daniel Vetter wrote: > > On Tue, Jun 24, 2014 at 10:52:13PM +0100, Masaru Nomura wrote: > >> removed drm_open_hash from drm_ht_remove_item() as the parameter is > >> not used within the function. > >> > >> Signed-off-by: Masaru Nomura <massa.nomura@xxxxxxxxx> > >> --- > >> Please review this patch carefully. The reason the parameter is passed > >> might be some historical one or clarity of which drm_open_hash > >> we remove an item from. > > Reasons for this are probably lost. On the patch: > > > > Reviewed-by: Daniel Vetter <daniel.vetter@xxxxxxxx> > > Acked-by: Thomas Hellstrom <thellstrom@xxxxxxxxxx> > > > > > Aside: Imo we could/should just move all the users to directly employ the > > linux hashtab instead of partially reinventing the wheel here in drm. > > -Daniel > > > > Actually, in this case, the wheel was invented in drm before it was made > generic :). > It's possible to utilize part of "hashtable.h" but I don't think the > code size gain > will be major... Yeah, lots of work and little gain ;-) There needs to be a terribly boring and rainy day to get around to that ... -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/dri-devel
