Hello JJ, On 15/06/2014 11:11, Jean-Jacques Hiblot wrote: > > On 06/09/2014 06:04 PM, Boris BREZILLON wrote: >> The HLCDC IP available in some Atmel SoCs (i.e. sam9x5i.e. at91sam9n12, >> at91sam9x5 family or sama5d3 family) provide a PWM device. >> >> This driver add support for this PWM device. >> >> Signed-off-by: Boris BREZILLON <boris.brezillon@xxxxxxxxxxxxxxxxxx> >> --- >> .../devicetree/bindings/pwm/atmel-hlcdc-pwm.txt | 40 ++++ >> drivers/pwm/Kconfig | 9 + >> drivers/pwm/Makefile | 1 + >> drivers/pwm/pwm-atmel-hlcdc.c | 216 +++++++++++++++++++++ >> 4 files changed, 266 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/pwm/atmel-hlcdc-pwm.txt >> create mode 100644 drivers/pwm/pwm-atmel-hlcdc.c >> >> diff --git a/Documentation/devicetree/bindings/pwm/atmel-hlcdc-pwm.txt b/Documentation/devicetree/bindings/pwm/atmel-hlcdc-pwm.txt >> new file mode 100644 >> index 0000000..5e2ba87 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/pwm/atmel-hlcdc-pwm.txt >> @@ -0,0 +1,40 @@ [...] >> +++ b/drivers/pwm/Kconfig >> @@ -50,6 +50,15 @@ config PWM_ATMEL >> To compile this driver as a module, choose M here: the module >> will be called pwm-atmel. >> >> +config PWM_ATMEL_HLCDC_PWM >> + tristate "Atmel HLCDC PWM support" >> + depends on MFD_ATMEL_HLCDC > I'd personnaly prefer a 'select' instead of 'depends on' here. Or maybe > the MFD driver should enabled y defaut for platforms supporting the hlcdc. I don't have any strong opinion on the "select" vs "depends on" approach. Does anyone else think we should use a 'select' instead of a 'depends on' ? I see at least one benefit, we would be able to see the HLCDC_PWM option even if the HLCDC driver is not enabled. Best Regards, Boris -- Boris Brezillon, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/dri-devel
