Re: [PATCH] drm/radeon: don't allow RADEON_GEM_DOMAIN_CPU for command submission

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Am 27.05.2014 02:56, schrieb Marek Olšák:
From: Marek Olšák <marek.olsak@xxxxxxx>

It hangs the hardware.

Signed-off-by: Marek Olšák <marek.olsak@xxxxxxx>

Reviewed-by: Christian König <christian.koenig@xxxxxxx>

Maybe CC stable as well? Anyway going to add it to my 3.15 queue.

Christian.

---
  drivers/gpu/drm/radeon/radeon_cs.c | 6 ++++++
  1 file changed, 6 insertions(+)

diff --git a/drivers/gpu/drm/radeon/radeon_cs.c b/drivers/gpu/drm/radeon/radeon_cs.c
index 2b6e0eb..2b78191 100644
--- a/drivers/gpu/drm/radeon/radeon_cs.c
+++ b/drivers/gpu/drm/radeon/radeon_cs.c
@@ -152,6 +152,12 @@ static int radeon_cs_parser_relocs(struct radeon_cs_parser *p)
  			uint32_t domain = r->write_domain ?
  				r->write_domain : r->read_domains;
+ if (domain & RADEON_GEM_DOMAIN_CPU) {
+				DRM_ERROR("RADEON_GEM_DOMAIN_CPU is not valid "
+					  "for command submission\n");
+				return -EINVAL;
+			}
+
  			p->relocs[i].domain = domain;
  			if (domain == RADEON_GEM_DOMAIN_VRAM)
  				domain |= RADEON_GEM_DOMAIN_GTT;

_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/dri-devel





[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux