On Tue, May 20, 2014 at 6:14 AM, Stephen Warren <swarren@xxxxxxxxxxxxx> wrote:
> On 05/19/2014 03:24 AM, Alexandre Courbot wrote:
>> Add the device tree binding documentation for the GK20A GPU used in
>> Tegra K1 SoCs.
>
> A few minor nits, but otherwise,
> Acked-by: Stephen Warren <swarren@xxxxxxxxxx>
>
>> diff --git a/Documentation/devicetree/bindings/gpu/nvidia,gk20a.txt b/Documentation/devicetree/bindings/gpu/nvidia,gk20a.txt
>
>> +Required properties:
>> +- compatible: "nvidia,<chip>-<gpu>"
>> + Currently recognized values:
>> + - nvidia,tegra124-gk20a
>> +- reg: Physical base address and length of the controller's registers.
>> + Must contain two entries:
>> + - first entry for bar0
>> + - second entry for bar1
>> +- interrupts: The interrupt outputs from the controller.
>
> To be consistent with the clocks and resets properties, it'd be nice to
> reword that as:
>
> interrupts: Must contain an entry for each entry in interrupt-names.
>
>> +- interrupt-names: Must include the following entries:
>
> ... and add the following here:
>
> See ../interrupt-controller/interrupts.txt
>
>> +/ {
>
> No need to wrap a root node around this in the example.
>
>> + gpu@0,57000000 {
> ...
>> + };
>> +
>
> Extra blank line here.
>
>> +};
>
All fixed and acked-by added to the commit log.
Thanks,
Alex.
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/dri-devel
