On 22 May 2014 12:06, Rahul Sharma <rahul.sharma@xxxxxxxxxxx> wrote: > On 22 May 2014 11:51, Sachin Kamat <sachin.kamat@xxxxxxxxxx> wrote: >> Hi Rahul, > [snip] >>> >>> + clk_prepare_enable(ctx->bus_clk); >> >> Probably a check for its success? >> >>> + clk_prepare_enable(ctx->lcd_clk); >> > > Generally we don't check this in any of the driver. It will be > quite unnecessary. However in your case, since you mentioned if the clock is not enabled, it will hang the system when fimd probe tries to read the register, this check would ensure it doesn't happen (hang) even if clk_prepare_enable fails for whatever reasons. -- With warm regards, Sachin _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/dri-devel
