On Thu, May 22, 2014 at 12:06:16PM +0530, Rahul Sharma wrote: > On 22 May 2014 11:51, Sachin Kamat <sachin.kamat@xxxxxxxxxx> wrote: > > Hi Rahul, > [snip] > >> > >> + clk_prepare_enable(ctx->bus_clk); > > > > Probably a check for its success? > > > >> + clk_prepare_enable(ctx->lcd_clk); > > > > Generally we don't check this in any of the driver. It will be > quite unnecessary. Then those drivers are all buggy. There's a reason why this function returns an int rather than void. Just because you've never seen it fail doesn't mean it can't. Thierry
Attachment:
pgppw9ULuW8GU.pgp
Description: PGP signature
_______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/dri-devel
