I didn't spot anything else, so with the below issue addressed this patch is Reviewed-by: Daniel Vetter <daniel.vetter@xxxxxxxx> On Sat, May 17, 2014 at 12:43:04AM +0200, Daniel Vetter wrote: > On Sat, May 17, 2014 at 12:38 AM, Matt Roper <matthew.d.roper@xxxxxxxxx> wrote: > > + if (ret) { > > + if (req->flags & DRM_MODE_CURSOR_BO) > > + drm_mode_rmfb(dev, &fb->base.id, file_priv); > > + return ret; > > + } > > With the new refcount logic an unconditional > drm_framebuffer_unreference should be here instead of this. I think, > but please double-check since it's late here ;-) > -Daniel > -- > Daniel Vetter > Software Engineer, Intel Corporation > +41 (0) 79 365 57 48 - http://blog.ffwll.ch -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/dri-devel