On 17 May 2014 01:34, Rafał Miłecki <zajec5@xxxxxxxxx> wrote: > On 17 May 2014 00:00, Alex Deucher <alexdeucher@xxxxxxxxx> wrote: >> On Fri, May 16, 2014 at 5:10 AM, Rafał Miłecki <zajec5@xxxxxxxxx> wrote: >>> +#define DCE3_HDMI0_AUDIO_CRC_CONTROL 0x74dc >> >> They aren't swapped in hw, the register defines were just accidentally >> swapped in the header (probably a copy paste typo). Just swap the >> defines. No need to keep the old values. > > Are you sure about this? I've doubts because fglrx indeed uses > 0x74dc for DCE2 > 0x740c for DCE3 > > Previously you wrote: "On DCE3, they should be ...". > > I suspect we may still need old defines to support DCE2. I was right. I've just compiled radeon with: acr_ctl = 0x740c; and tested it on DCE2. Audio didn't work. Some debugging: # avivotool regsrange 0x740c 0x740c 0000740c 00001100 (4352) # avivotool regsrange 0x74dc 0x74dc 000074dc 00000000 (0) As expected, audio was fixed by exeuting: # avivotool regset 0x74dc 0x00001100 So it's the fact: DCE2 uses 0x74dc DCE2 uses 0x740c So I believe my patch is OK. -- Rafał _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/dri-devel
