Re: [PATCH 09/10] i915: add DP 1.2 MST support (v0.3)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



>
> So we leak all dynamically created objects? There's no
> kfree(intel_connector) here and we cannot add it because
> drm_mode_object_find() is not ref-counted. So we keep the connector in
> the mode_group and wait until the final drm_mode_config_cleanup()? But
> drm_connector_cleanup() already removes the connector from the
> mode-group, so we eventually leak the object.
>

Seems like freeing it should be fine, it was just an oversight,

Since any objects you get with find are only valid under mode_config.mutex,
yes some drivers mess this up, but they should be fixed.

Dave.
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/dri-devel




[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux