On Mon, May 12, 2014 at 04:46:42PM +1000, Dave Airlie wrote:
> From: Dave Airlie <airlied@xxxxxxxxxx>
>
> This property will be used by the MST code to provide userspace
> with a path to parse so it can recognise connectors around hotplugs.
>
> Signed-off-by: Dave Airlie <airlied@xxxxxxxxxx>
> ---
> drivers/gpu/drm/drm_crtc.c | 26 ++++++++++++++++++++++++++
> include/drm/drm_crtc.h | 5 +++++
> 2 files changed, 31 insertions(+)
The documentation for this property is missing. =)
> diff --git a/drivers/gpu/drm/drm_crtc.c b/drivers/gpu/drm/drm_crtc.c
[...]
> +int drm_mode_connector_set_path_property(struct drm_connector *connector,
> + char *path)
"const char *path"?
> +{
> + struct drm_device *dev = connector->dev;
> + int ret, size;
> + size = strlen(path) + 1;
At the risk of sounding pedantic: strlen() returns size_t, not int. But
I see that drm_property_create_blob() uses int as the type for the
length argument, so there's an inconsistency either way. I'll go prepare
a patch to fix that inconsistency and see if anybody else is equally
pedantic and willing to apply it.
Thierry
Attachment:
pgpcBEjzLhy5c.pgp
Description: PGP signature
_______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/dri-devel
