On Tue, Apr 8, 2014 at 8:19 AM, Benjamin Gaignard <benjamin.gaignard@xxxxxxxxxx> wrote: > +/* > + * Attach the I2C ddc client to allow hdmi i2c communication > + * > + * @ddc: i2c client > + */ > +static struct i2c_client *hdmi_ddc; > +void sti_hdmi_attach_ddc_client(struct i2c_client *ddc) > +{ > + DRM_DEBUG_DRIVER("\n"); > + > + if (ddc) > + hdmi_ddc = ddc; > +} > + you should have a look at the 'componentized device' support (ie drivers/base/component.c) for collecting up all the sub-devices you need. Gets rid of all these global ptrs. Probably want to do that before posting v2.. BR, -R _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/dri-devel