Atomicity in KMS panic notifier

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

while debugging a few reported bugs, I noticed that
drm_fb_helper_force_kernel_mode() that is called in the KMS panic
notifier isn't really atomic-safe.  It invokes crtc's set_config(),
and all implementations seem to involve with page allocations (kmalloc
with GFP_KERNEL, via some ttm ops, etc).  I've actually seen the Oops
with cirrus KMS during panic due to this.

Does anyone have an idea to fix this?  I thought of re-using
drm_fb_helper_debug_enter(), but this won't work with many drivers
that don't have crtc->mode_set_base_atomic(), either (yeah, this is
another bug).


thanks,

Takashi
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/dri-devel




[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux