Re: [PATCH v2 libdrm 5/7] tegra: Add helper library for tests

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Apr 9, 2014 at 1:40 PM, Thierry Reding <thierry.reding@xxxxxxxxx> wrote:
> +int drm_open(const char *path)
> +{
> +       int fd, err;
> +
> +       fd = open(path, O_RDWR);
> +       if (fd < 0)
> +               return -errno;
> +
> +       err = drmSetMaster(fd);
> +       if (err < 0) {
> +               close(fd);
> +               return -errno;
> +       }

Could we make this opt-in? Otherwise "make check" needs to be run as
root to pass, which is a bit iffy IMO as it also invokes the compiler
and all tools as root. I'd prefer not having to give my dev-tools (and
potentially buggy in-tree scripts) that much privilege...
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/dri-devel




[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux