On 22.04.2014 21:51, Alex Deucher wrote: > On Tue, Apr 22, 2014 at 3:53 AM, Michel Dänzer <michel@xxxxxxxxxxx> wrote: >> From: Michel Dänzer <michel.daenzer@xxxxxxx> >> >> The way the tile mode array index was calculated only makes sense for >> the CIK specific macrotile mode array. For SI, we need to use one of the >> tile mode array indices reserved for displayable surfaces. >> >> This happened to result in correct display most if not all of the time >> because most of the SI tiling modes use the same number of banks. >> >> Signed-off-by: Michel Dänzer <michel.daenzer@xxxxxxx> > > Thanks for doing this. > > Reviewed-by: Alex Deucher <alexander.deucher@xxxxxxx> Thanks Alex. > Christian, can you cc stable when you pick this up? Actually, I deliberately left that out, as the previous code mostly seems to calculate the same result in practice, just not in the correct way. So I'm not sure it's worth taking any risk for stable, however small it may be. We can still nominate it for stable later if it turns out to fix an actual problem in practice. Anyway, I can't seem to find this patch in any DRM tree yet. Christian, did you see it? -- Earthling Michel Dänzer | http://www.amd.com Libre software enthusiast | Mesa and X developer _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/dri-devel
