On Mon, Apr 28, 2014 at 4:57 PM, Thierry Reding <thierry.reding@xxxxxxxxx> wrote: > On Mon, Apr 28, 2014 at 12:10:27PM +1000, Ben Skeggs wrote: >> On Fri, Apr 25, 2014 at 5:19 PM, Alexandre Courbot <acourbot@xxxxxxxxxx> wrote: >> > nvc0_graph_ctor() would only let the graphics engine be enabled if its >> > oclass has a proper microcode linked to it. This prevents GR from being >> > enabled at all on chips that rely exclusively on external firmware, even >> > though such a use-case is valid. >> > >> > Relax the conditions enabling the GR engine to also include the case >> > where an external firmware has also been loaded. >> I'm happy to take this patch as-is. I do wonder if we should do >> something like this though: >> >> if (nouveau_boolopt(device->cfgopt, "NvGrUseFW", oclass->fecs.ucode == NULL)) >> >> Which will automatically switch to external firmware if there's no >> internal implementation available. > > I think that makes a lot of sense. Perhaps outputting a warning or so at > runtime when this happens would be helpful in reminding people that the > goal is to make the GPU run with nouveau firmware rather than external > firmware, and hence that there's some work left to do. That already happens with a "using external firmware" notice. > > Thierry _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/dri-devel
