Re: [PATCH] drm: Missed clflushopt in drm_clflush_virt_range

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi

On Mon, Apr 21, 2014 at 10:28 PM, Ross Zwisler
<ross.zwisler@xxxxxxxxxxxxxxx> wrote:
> On Wed, 2 Apr 2014, Ross Zwisler wrote:
>> With this commit:
>>
>> 2a0788dc9bc4 x86: Use clflushopt in drm_clflush_virt_range
>>
>> If clflushopt is available on the system, we use it instead of clflush
>> in drm_clflush_virt_range.  There were two calls to clflush in this
>> function, but only one was changed to clflushopt.  This patch changes
>> the other clflush call to clflushopt.
>>
>> Signed-off-by: Ross Zwisler <ross.zwisler@xxxxxxxxxxxxxxx>
>> Reported-by: Matthew Wilcox <matthew.r.wilcox@xxxxxxxxx>
>> ---
>>  drivers/gpu/drm/drm_cache.c |    2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/drm_cache.c b/drivers/gpu/drm/drm_cache.c
>> index 534cb89..041b73b 100644
>> --- a/drivers/gpu/drm/drm_cache.c
>> +++ b/drivers/gpu/drm/drm_cache.c
>> @@ -138,7 +138,7 @@ drm_clflush_virt_range(char *addr, unsigned long length)
>>               char *end = addr + length;
>>               mb();
>>               for (; addr < end; addr += boot_cpu_data.x86_clflush_size)
>> -                     clflush(addr);
>> +                     clflushopt(addr);
>>               clflushopt(end - 1);
>>               mb();
>>               return;
>> --
>> 1.7.10.4
>
> Ping?  :)

This was merged through -tip, right? The DRM tree does not include the
initial patches, yet, so I'd recommend merging this through -tip
again. I've put hpa on CC for that. However, I cannot see where the
initial patch was sent to, so can you resent it properly to lkml,
please? And please also put the respective maintainers on CC.

Thanks
David
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/dri-devel




[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux