On Fri, Apr 11, 2014 at 11:36:00PM +0200, Daniel Vetter wrote:
[...]
> +int drm_irq_by_busid(struct drm_device *dev, void *data,
> + struct drm_file *file_priv)
> +{
> + struct drm_irq_busid *p = data;
> +
> + if (drm_core_check_feature(dev, DRIVER_MODESET))
> + return -EINVAL;
> +
> + /* UMS was only ever support on pci devices. */
Nit: s/pci/PCI?
> + if (WARN_ON(!dev->pdev))
> + return -EINVAL;
> +
> + if (!drm_core_check_feature(dev, DRIVER_HAVE_IRQ))
> + return -EINVAL;
> +
> + return drm_pci_irq_by_busid(dev, p);
> +}
> +
> +
Nit: there's a gratuitous blank line introduced here.
Other than that:
Reviewed-by: Thierry Reding <treding@xxxxxxxxxx>
Attachment:
pgpRaUEE1I5y6.pgp
Description: PGP signature
_______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/dri-devel
