Re: [RFC PATCH 14/14] ARM: dts: exynos5420: add dsi node

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi YoungJun,

On 15 April 2014 11:17, YoungJun Cho <yj44.cho@xxxxxxxxxxx> wrote:
> This patch adds common part of dsi node.
>
> Signed-off-by: YoungJun Cho <yj44.cho@xxxxxxxxxxx>
> Signed-off-by: Inki Dae <inki.dae@xxxxxxxxxxx>
> Signed-off-by: Kyungmin Park <kyungmin.park@xxxxxxxxxxx>
> ---
>  arch/arm/boot/dts/exynos5420.dtsi |   14 ++++++++++++++
>  1 file changed, 14 insertions(+)
>
> diff --git a/arch/arm/boot/dts/exynos5420.dtsi b/arch/arm/boot/dts/exynos5420.dtsi
> index f0184c7..aa2350a 100644
> --- a/arch/arm/boot/dts/exynos5420.dtsi
> +++ b/arch/arm/boot/dts/exynos5420.dtsi
> @@ -422,6 +422,20 @@
>                 #phy-cells = <1>;
>         };
>
> +       dsi@14500000 {
> +               compatible = "samsung,exynos5420-mipi-dsi";
> +               reg = <0x14500000 0x10000>;
> +               interrupts = <0 82 0>;
> +               samsung,power-domain = <&disp_pd>;
> +               phys = <&mipi_phy 1>;
> +               phy-names = "dsim";
> +               clocks = <&clock 411>, <&clock 146>;

Please use macros instead of numbers.

> +               clock-names = "bus_clk", "pll_clk";
> +               status = "disabled";

nit: Move this to the end for readability.

-- 
With warm regards,
Sachin
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/dri-devel




[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux