On Mon, Apr 7, 2014 at 4:35 PM, Alex Deucher <alexdeucher@xxxxxxxxx> wrote: > On Mon, Apr 7, 2014 at 5:37 AM, Jani Nikula <jani.nikula@xxxxxxxxx> wrote: >> To support bare address requests used by the drm dp helpers. >> >> Signed-off-by: Jani Nikula <jani.nikula@xxxxxxxxx> >> >> --- >> >> Hi Alex, similar to Thierry's patch for i915. >> > > Looks good to me. > > Reviewed-by: Alex Deucher <alexander.deucher@xxxxxxx> > > Do you want me to add this to the patch set? Afaict we've done an unconditional msg_bytes = send_bytes + 4; in the i915 driver before the conversion to the dp aux helper, which is why I've slapped an r-b onto your patch without asking for a i915 adjustement. Otoh we have a pile of bugs for dp dongles still. Imo my preferred approach would be to get the helper + radeon stuff in and then hawk the i915 patch to a bunch of bug reporter and see whether it sticks. Ofc if we already know that we need it it would be best to merge it in one pull together with all your other patches. Jani? -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/dri-devel
