2014-03-18 22:04 GMT+09:00 Tomasz Figa <t.figa@xxxxxxxxxxx>: > Hi Shirish, > > > On 13.03.2014 06:28, Shirish S wrote: >> >> Now that the drm_display_mode also provides aspect >> ratio for all resolutions, this patch adds its usage >> to set the active aspect ratio of AVI info frame >> packets as per CEA-861-D standard's Table 9. >> >> This is also needed to abide by the 7-27 >> compliance test of HDMI. >> >> Signed-off-by: Shirish S <s.shirish@xxxxxxxxxxx> >> --- >> V2: rebased on new branch >> V3: Incorporated review comments >> >> drivers/gpu/drm/exynos/exynos_hdmi.c | 35 >> +++++++++++++++++++++++++++------- >> 1 file changed, 28 insertions(+), 7 deletions(-) >> >> diff --git a/drivers/gpu/drm/exynos/exynos_hdmi.c >> b/drivers/gpu/drm/exynos/exynos_hdmi.c >> index 12fdf55..9b0b617 100644 >> --- a/drivers/gpu/drm/exynos/exynos_hdmi.c >> +++ b/drivers/gpu/drm/exynos/exynos_hdmi.c >> @@ -53,12 +53,13 @@ >> /* AVI header and aspect ratio */ >> #define HDMI_AVI_VERSION 0x02 >> #define HDMI_AVI_LENGTH 0x0D >> -#define AVI_PIC_ASPECT_RATIO_16_9 (2 << 4) >> -#define AVI_SAME_AS_PIC_ASPECT_RATIO 8 >> >> /* AUI header info */ >> #define HDMI_AUI_VERSION 0x01 >> #define HDMI_AUI_LENGTH 0x0A >> +#define AVI_SAME_AS_PIC_ASPECT_RATIO 0x8 >> +#define AVI_4_3_CENTER_RATIO 0x9 >> +#define AVI_16_9_CENTER_RATIO 0xa > > > One minor nitpick: Please don't use tabs between #define and macro name. > Fixed and applied. Thanks, Inki Dae > After fixing this issue feel free to add my: > > Reviewed-by: Tomasz Figa <t.figa@xxxxxxxxxxx> > > Best regards, > Tomasz > > _______________________________________________ > dri-devel mailing list > dri-devel@xxxxxxxxxxxxxxxxxxxxx > http://lists.freedesktop.org/mailman/listinfo/dri-devel _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/dri-devel
