Re: [PATCH] drm: armada: Use devm_ioremap_resource()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



David,

On Mon, Feb 10, 2014 at 7:57 PM, Fabio Estevam <festevam@xxxxxxxxx> wrote:
> From: Fabio Estevam <fabio.estevam@xxxxxxxxxxxxx>
>
> devm_request_and_ioremap() is deprecated, so use devm_ioremap_resource()
> instead.
>
> Signed-off-by: Fabio Estevam <fabio.estevam@xxxxxxxxxxxxx>
> ---

Any comments about this one?


>  drivers/gpu/drm/armada/armada_crtc.c | 8 +++-----
>  1 file changed, 3 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/gpu/drm/armada/armada_crtc.c b/drivers/gpu/drm/armada/armada_crtc.c
> index d8e3982..2b6e7b7 100644
> --- a/drivers/gpu/drm/armada/armada_crtc.c
> +++ b/drivers/gpu/drm/armada/armada_crtc.c
> @@ -1037,11 +1037,9 @@ int armada_drm_crtc_create(struct drm_device *dev, unsigned num,
>         if (ret)
>                 return ret;
>
> -       base = devm_request_and_ioremap(dev->dev, res);
> -       if (!base) {
> -               DRM_ERROR("failed to ioremap register\n");
> -               return -ENOMEM;
> -       }
> +       base = devm_ioremap_resource(dev->dev, res);
> +       if (IS_ERR(base))
> +               return PTR_ERR(base);
>
>         dcrtc = kzalloc(sizeof(*dcrtc), GFP_KERNEL);
>         if (!dcrtc) {
> --
> 1.8.1.2
>
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/dri-devel




[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux