Hi On Fri, Feb 21, 2014 at 8:01 AM, Thierry Reding <thierry.reding@xxxxxxxxx> wrote: > On Wed, Jan 29, 2014 at 03:01:52PM +0100, David Herrmann wrote: > [...] >> diff --git a/drivers/gpu/drm/drm_stub.c b/drivers/gpu/drm/drm_stub.c > [...] >> @@ -486,12 +490,10 @@ EXPORT_SYMBOL(drm_dev_alloc); >> * @dev: DRM device to free >> * >> * Free a DRM device that has previously been allocated via drm_dev_alloc(). >> - * You must not use kfree() instead or you will leak memory. >> - * >> - * This must not be called once the device got registered. Use drm_put_dev() >> - * instead, which then calls drm_dev_free(). >> + * This may not be called directly, you must use drm_dev_ref() and >> + * drm_dev_unref() to gain and drop references to the object. >> */ >> -void drm_dev_free(struct drm_device *dev) >> +static void drm_dev_free(struct drm_device *dev) > > With the function turning static it can't be called from anywhere else > but this file, so perhaps the last sentence of the comment can now go > away as well? Yepp, fixed. Thanks David _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/dri-devel
