Re: [PATCH 4/6] android: convert sync to fence api, v4

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



op 19-02-14 14:56, Thomas Hellstrom schreef:
>+static void fence_check_cb_func(struct fence *f, struct fence_cb *cb)
>+{
>+	struct sync_fence_cb *check = container_of(cb, struct sync_fence_cb, cb);
>+	struct sync_fence *fence = check->fence;
>+
>+	// TODO: Add a fence->status member and check it
Hmm, C++ / C99 style comments makes checkpatch.pl complain. Did you run
this series through checkpatch?

/Thomas

Actually I used c99 here because it shouldn't have been in the sent patch. ;-)

Right below that comment I use fence->status, so the right thing to do was to zap the comment.

Thanks for catching it!

~Maarten\
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/dri-devel




[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux