2014-02-14 16:34 GMT+09:00 Shirish S <s.shirish@xxxxxxxxxxx>: > In DVI mode the video preamble and Guard band should > be disabled whereas it should be applied in HDMI mode, > the re-applying of preamble and guard band was missing, > which resulted in display failures when switched to HDMI > mode from DVI mode. > This patch ensures the setting is applied in HDMI mode. > > Signed-off-by: Shirish S <s.shirish@xxxxxxxxxxx> > --- > drivers/gpu/drm/exynos/exynos_hdmi.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/gpu/drm/exynos/exynos_hdmi.c b/drivers/gpu/drm/exynos/exynos_hdmi.c > index a0e10ae..a102076 100644 > --- a/drivers/gpu/drm/exynos/exynos_hdmi.c > +++ b/drivers/gpu/drm/exynos/exynos_hdmi.c > @@ -994,6 +994,8 @@ static void hdmi_conf_init(struct hdmi_context *hdata) > /* choose HDMI mode */ > hdmi_reg_writemask(hdata, HDMI_MODE_SEL, > HDMI_MODE_HDMI_EN, HDMI_MODE_MASK); > + /* Apply Video preable and Guard band in HDMI mode only */ > + hdmi_reg_writeb(hdata, HDMI_CON_2, 0); Isn't hdmi_conf_init function always called after hdmi core is reset? And HDMI_CON_2 would have 0 as reset value. It seems that your code isn't meaningful. If you want to set HDMI_CON_2 to HDMI mode in there then it would better to use meaningful macro, HDMI_VID_PREAMBLE_DIS and HDMI_GUARD_BAND_DIS. Thanks, Inki Dae > /* disable bluescreen */ > hdmi_reg_writemask(hdata, HDMI_CON_0, 0, HDMI_BLUE_SCR_EN); > > -- > 1.7.9.5 > > _______________________________________________ > dri-devel mailing list > dri-devel@xxxxxxxxxxxxxxxxxxxxx > http://lists.freedesktop.org/mailman/listinfo/dri-devel _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/dri-devel
