On Mon, Jan 27, 2014 at 08:44:41PM +0000, Mark Brown wrote: > On Mon, Jan 27, 2014 at 09:48:54AM +0100, Jean-Francois Moine wrote: > > > + eld_ver = eld[0] >> 3; > > + if (eld_ver != 2 && eld_ver != 31) > > + return 0; > > + > > + mnl = eld[4] & 0x1f; > > + if (mnl > 16) > > + return 0; > > + > > + sad_count = eld[5] >> 4; > > + sad = eld + 20 + mnl; > > Can this parsing code be factored out - it (or large parts of it) should > be usable by other HDMI devices shouldn't it? Yes, preferably as a generic ALSA helper rather than an ASoC helper - I don't see any need for this to be ASoC specific (I have a pure ALSA driver which has very similar code in it.) -- FTTC broadband for 0.8mile line: 5.8Mbps down 500kbps up. Estimation in database were 13.1 to 19Mbit for a good line, about 7.5+ for a bad. Estimate before purchase was "up to 13.2Mbit". _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/dri-devel
