On Sun, Jan 19, 2014 at 07:58:43PM +0100, Jean-Francois Moine wrote: > This patch fixes a NULL pointer dereference when the set_config > function has not been called (priv->params == NULL). No, that's not what this patch is doing. Maybe you could enlighten me how priv->params could ever be NULL when that is _not_ a pointer? That's completely impossible as it isn't a pointer. If you tried "priv->params = NULL" the C compiler would barf on it. I suspect you've misunderstood the code, and this change isn't actually necessary. -- FTTC broadband for 0.8mile line: 5.8Mbps down 500kbps up. Estimation in database were 13.1 to 19Mbit for a good line, about 7.5+ for a bad. Estimate before purchase was "up to 13.2Mbit". _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/dri-devel