On Thu, Jan 09, 2014 at 12:07:25PM +0100, Jean-Francois Moine wrote: > This patch reduces the number of I2C exchanges by setting many bits in > one write and removing a useless write. > > Signed-off-by: Jean-Francois Moine <moinejf@xxxxxxx> > --- > drivers/gpu/drm/i2c/tda998x_drv.c | 10 ++++------ > 1 file changed, 4 insertions(+), 6 deletions(-) > > diff --git a/drivers/gpu/drm/i2c/tda998x_drv.c b/drivers/gpu/drm/i2c/tda998x_drv.c > index 6b4f6d2..d3b3f3a 100644 > --- a/drivers/gpu/drm/i2c/tda998x_drv.c > +++ b/drivers/gpu/drm/i2c/tda998x_drv.c > @@ -751,10 +751,10 @@ tda998x_configure_audio(struct tda998x_priv *priv, > } > > reg_write(priv, REG_AIP_CLKSEL, clksel_aip); > - reg_clear(priv, REG_AIP_CNTRL_0, AIP_CNTRL_0_LAYOUT); > + reg_clear(priv, REG_AIP_CNTRL_0, AIP_CNTRL_0_LAYOUT | This patch clearly hasn't even been build tested, so I doubt there's much point reviewing this or the following patches. From a quick scan of the following patches, this never got fixed so the following patches can't have been build tested either. Thanks. -- FTTC broadband for 0.8mile line: 5.8Mbps down 500kbps up. Estimation in database were 13.1 to 19Mbit for a good line, about 7.5+ for a bad. Estimate before purchase was "up to 13.2Mbit". _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/dri-devel
