On Mon, Jan 6, 2014 at 10:21 AM, Rashika Kheria <rashika.kheria@xxxxxxxxx> wrote: > Mark functions radeon_doorbell_init() and radeon_doorbell_fini() as > static in drm/radeon/radeon_device.c because they are not used outside > this file. > > This eliminates the following warning in drm/radeon/radeon_device.c: > drivers/gpu/drm/radeon/radeon_device.c:252:5: warning: no previous prototype for ‘radeon_doorbell_init’ [-Wmissing-prototypes] > drivers/gpu/drm/radeon/radeon_device.c:281:6: warning: no previous prototype for ‘radeon_doorbell_fini’ [-Wmissing-prototypes] > > Signed-off-by: Rashika Kheria <rashika.kheria@xxxxxxxxx> > Reviewed-by: Josh Triplett <josh@xxxxxxxxxxxxxxxx> I've pulled in a subset of these patches: http://cgit.freedesktop.org/~agd5f/linux/log/?h=drm-next-3.14-wip I held off on some of the others as I'd rather fix up the headers properly rather than just cramming everything in radeon.h or radeon-asic.h for now. Thanks! Alex > --- > drivers/gpu/drm/radeon/radeon_device.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/radeon/radeon_device.c b/drivers/gpu/drm/radeon/radeon_device.c > index 39b033b..caf4975 100644 > --- a/drivers/gpu/drm/radeon/radeon_device.c > +++ b/drivers/gpu/drm/radeon/radeon_device.c > @@ -249,7 +249,7 @@ void radeon_scratch_free(struct radeon_device *rdev, uint32_t reg) > * Init doorbell driver information (CIK) > * Returns 0 on success, error on failure. > */ > -int radeon_doorbell_init(struct radeon_device *rdev) > +static int radeon_doorbell_init(struct radeon_device *rdev) > { > /* doorbell bar mapping */ > rdev->doorbell.base = pci_resource_start(rdev->pdev, 2); > @@ -278,7 +278,7 @@ int radeon_doorbell_init(struct radeon_device *rdev) > * > * Tear down doorbell driver information (CIK) > */ > -void radeon_doorbell_fini(struct radeon_device *rdev) > +static void radeon_doorbell_fini(struct radeon_device *rdev) > { > iounmap(rdev->doorbell.ptr); > rdev->doorbell.ptr = NULL; > -- > 1.7.9.5 > > _______________________________________________ > dri-devel mailing list > dri-devel@xxxxxxxxxxxxxxxxxxxxx > http://lists.freedesktop.org/mailman/listinfo/dri-devel _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/dri-devel
