On 01/07/2014 11:51 AM, Josh Triplett wrote: > On Tue, Jan 07, 2014 at 11:21:12AM +0100, Jakob Bornecrantz wrote: >> On Mon, Jan 6, 2014 at 5:48 PM, Rashika Kheria <rashika.kheria@xxxxxxxxx> wrote: >>> Mark functions as static because they are not used outside the file >>> drm/vmwgfx/vmwgfx_kms.c. >>> >>> This eliminates the following warnings in drm/vmwgfx/vmwgfx_kms.c: >>> drivers/gpu/drm/vmwgfx/vmwgfx_kms.c:43:6: warning: no previous prototype for ‘vmw_clip_cliprects’ [-Wmissing-prototypes] >>> drivers/gpu/drm/vmwgfx/vmwgfx_kms.c:426:6: warning: no previous prototype for ‘vmw_framebuffer_surface_destroy’ [-Wmissing-prototypes] >>> drivers/gpu/drm/vmwgfx/vmwgfx_kms.c:592:5: warning: no previous prototype for ‘vmw_framebuffer_surface_dirty’ [-Wmissing-prototypes] >>> drivers/gpu/drm/vmwgfx/vmwgfx_kms.c:757:6: warning: no previous prototype for ‘vmw_framebuffer_dmabuf_destroy’ [-Wmissing-prototypes] >>> drivers/gpu/drm/vmwgfx/vmwgfx_kms.c:943:5: warning: no previous prototype for ‘vmw_framebuffer_dmabuf_dirty’ [-Wmissing-prototypes] >>> drivers/gpu/drm/vmwgfx/vmwgfx_kms.c:1666:5: warning: no previous prototype for ‘vmw_du_update_layout’ [-Wmissing-prototypes] >>> >>> Signed-off-by: Rashika Kheria <rashika.kheria@xxxxxxxxx> >>> Reviewed-by: Josh Triplett <josh@xxxxxxxxxxxxxxxx> >>> --- >>> drivers/gpu/drm/vmwgfx/vmwgfx_kms.c | 12 ++++++------ >>> 1 file changed, 6 insertions(+), 6 deletions(-) >> >> This and patch 83, 84, 85 are >> Reviewed-by: Jakob Bornecrantz <jakob@xxxxxxxxxx> > Can you take them through your tree, or are you expecting them to follow > another path? I'll take them through vmwgfx-next. However, patch 83/85 conflicts heavily with an internal vmwgfx patch series. If applicable, I'll apply it after resolving those conflicts. Thanks, /Thomas > > - Josh Triplett > _______________________________________________ > dri-devel mailing list > dri-devel@xxxxxxxxxxxxxxxxxxxxx > http://lists.freedesktop.org/mailman/listinfo/dri-devel _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/dri-devel
